Skip to content

improve scrolling vs selection interactions #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

improve scrolling vs selection interactions #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/typography/textboxes.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ type TextBox* = ref object
vAlign*: VAlignMode
hAling*: HAlignMode
scrollable*: bool
wasScrolled*: bool
editable*: bool
scroll*: Vec2 # Scroll position.
font*: Font
Expand Down Expand Up @@ -195,7 +196,7 @@ proc removeSelection(textBox: TextBox) =

proc adjustScroll*(textBox: TextBox) =
## Adjust scroll to make sure cursor is in the window.
if textBox.scrollable:
if textBox.scrollable and not textBox.wasScrolled:
let
r = textBox.cursorRect
# is pos.y inside the window?
Expand Down Expand Up @@ -464,6 +465,7 @@ proc mouseAction*(
shift = false
) =
## Click on this with a mouse.
textBox.wasScrolled = false
textBox.mousePos = mousePos + textBox.scroll
# Pick where to place the cursor.
let pos = textBox.layout.pickGlyphAt(textBox.mousePos)
Expand Down Expand Up @@ -528,6 +530,7 @@ proc resize*(textBox: TextBox, size: Vec2) =

proc scrollBy*(textBox: TextBox, amount: float) =
## Scroll text box with a scroll wheel.
textBox.wasScrolled = true
textBox.scroll.y += amount
# Make sure it does not scroll off the top.
textBox.scroll.y = max(0, textBox.scroll.y)
Expand All @@ -538,4 +541,4 @@ proc scrollBy*(textBox: TextBox, amount: float) =
)
# Check if there is not enough text to scroll.
if textBox.innerHeight < textBox.height:
textBox.scroll.y = 0
textBox.scroll.y = 0