Bugfix for ScrollX / ScrollY in IE11 #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 16, 2019 12:17
…` (which is basically the same) to get compatibility in IE11. https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollY#Notes for more
…lier versions of plugin, while still retaining IE11 functionality.
Author
|
Now the naming in local storage is unchanged from before, so there's full backwards compatibility. Woo! |
Owner
|
It looks like we made the same, non-disruptive change simultaneously. 😄 I merged mine with your comment above, so I'm closing this PR. Thanks for reporting the issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
scrollXandscrollYwithpageXOffsetandpageYOffset(which is basically the same) to get scroll-compatibility in IE11. It does rename the properties in the local storage as well, but I don't know if this would be considered a breaking change for anyone?See https://developer.mozilla.org/en-US/docs/Web/API/Window/scrollY#Notes for information about the cross-browser compatibility.
pageXOffsetis a safer bet. :)