Skip to content

Conversation

jasonramirez
Copy link
Contributor

  • Shrink hero to 1/2 viewport height
  • Add example code steps
  • Add code highlighting via highlight.js

screen shot 2015-12-10 at 10 07 42 am

* Shrink hero to 1/2 viewport height
* Add example code steps
* Add code highlighting via highlight.js

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'hljs' is not defined.

_sass/_code.scss Outdated

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Properties should be ordered background-color, border, border-radius, font-size, margin-bottom

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector code__header should be written in lowercase with hyphens

@seanpdoyle
Copy link
Contributor

@jasonramirez this LOOKs amazing!

Unfortunately, the README has been recently updated, which makes a lot of this text out of date.

https://github.com/thoughtbot/ember-cli-rails#usage

I wonder if we could somehow style the page the way you've laid out and somehow import in some markdown.

Do you think styles are generic enough to work with a .md -> .html translation?

@seanpdoyle
Copy link
Contributor

ping @jasonramirez

P.S. the latest README and some upcoming changes make these snippets wildly out of date, which presents an even greater opportunity for supporting robust enough styles to make translating the README.md work out.

@jasonramirez
Copy link
Contributor Author

@seanpdoyle I'll remove the custom styles added by the <span> elements that made the code pretty. I added them because I couldn't find a good theme. This will make the styles more flexible. I think doing the .md -> .html translation should be in a separate PR.

@seanpdoyle
Copy link
Contributor

@jasonramirez agreed, a separate PR is a good idea.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selector should have depth of applicability no greater than 2, but was 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants