Skip to content

Conversation

oandreeva-nv
Copy link
Contributor

No description provided.

Copy link
Contributor

@the-david-oy the-david-oy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work, Olga! Added some minor comments.

the-david-oy
the-david-oy previously approved these changes Oct 31, 2023
Copy link
Contributor

@the-david-oy the-david-oy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added optional comments aimed at improving readability.

Copy link
Contributor

@the-david-oy the-david-oy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@oandreeva-nv oandreeva-nv merged commit 9a179ca into main Oct 31, 2023
@oandreeva-nv oandreeva-nv deleted the oandreeva_vllm_container_tutorial branch October 31, 2023 21:15
fdf3d186-88d5 pushed a commit to fdf3d186-88d5/triton-inference-server that referenced this pull request Mar 21, 2025
…ference-server#65)

* Updated vLLM tutorial's README to use vllm container

---------

Co-authored-by: dyastremsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants