-
-
Notifications
You must be signed in to change notification settings - Fork 195
feat/allowing multiple tags for operation meta #84
Conversation
operation meta taking an array of tags to allow multiple groupings meta - tag which took a string has been been renamed to tags which takes an array of strings
tag string to tags string[]
update examples to use the new tags prop in operations meta
reintroduce the tag meta prop, giving priority to the tags prop
@jlalmes Houston we have a problem. Things get weird with the nullish coalescing operator. EDIT: Just realized the first line is covered. 1. let tag; |
This seems to work 👉 |
My mathematics teacher would be embarrassed that I forgot about using brackets 😓. |
…tion simplifying nested ternaries for operation meta tags resolution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Ship it! ✅
@jlalmes we originally had |
@dodas It was me seeking a "better" DX, because it's very rare that I ever add more than one tag to an endpoint. I suppose having both is a good solution for the time-being. |
@jlalmes Squash and Merge? or is there a release pipeline/strategy for this? |
@SeanCassiere squash please! I will manually release after you've merged 👍 |
Release under |
Thanks a bunch for all your help. Was my second contribution to OSS and y'all made it great. |
Closes #82
Old PR: #83