add suport rect_border_radius to smtpads and plated hole #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+1
to
+95
| import { CadViewer } from "src/CadViewer" | ||
|
|
||
| const roundedRectPadsCircuit = [ | ||
| { | ||
| type: "pcb_board", | ||
| pcb_board_id: "board-rounded-rects", | ||
| center: { x: 0, y: 0 }, | ||
| thickness: 1.6, | ||
| num_layers: 2, | ||
| width: 70, | ||
| height: 40, | ||
| }, | ||
| { | ||
| type: "pcb_component", | ||
| pcb_component_id: "component-rounded", | ||
| source_component_id: "component-rounded", | ||
| center: { x: -15, y: 0 }, | ||
| width: 6, | ||
| height: 6, | ||
| layer: "top", | ||
| rotation: 0, | ||
| }, | ||
| { | ||
| type: "pcb_smtpad", | ||
| pcb_smtpad_id: "pad-top-rounded", | ||
| pcb_component_id: "component-rounded", | ||
| layer: "top", | ||
| shape: "rect", | ||
| width: 4, | ||
| height: 2, | ||
| x: -22, | ||
| y: 6, | ||
| rect_border_radius: 0.6, | ||
| }, | ||
| { | ||
| type: "pcb_smtpad", | ||
| pcb_smtpad_id: "pad-bottom-rounded", | ||
| pcb_component_id: "component-rounded", | ||
| layer: "top", | ||
| shape: "rotated_rect", | ||
| width: 4, | ||
| height: 2, | ||
| x: -2, | ||
| y: -6, | ||
| ccw_rotation: 35, | ||
| rect_border_radius: 0.6, | ||
| }, | ||
| { | ||
| type: "pcb_plated_hole", | ||
| pcb_plated_hole_id: "ph-circular", | ||
| x: 5, | ||
| y: 8, | ||
| shape: "circular_hole_with_rect_pad", | ||
| layers: ["top", "bottom"], | ||
| hole_diameter: 1.2, | ||
| rect_pad_width: 3, | ||
| rect_pad_height: 2.4, | ||
| rect_pad_border_radius: 0.6, | ||
| }, | ||
| { | ||
| type: "pcb_plated_hole", | ||
| pcb_plated_hole_id: "ph-pill-horizontal", | ||
| x: 7, | ||
| y: -8, | ||
| shape: "pill_hole_with_rect_pad", | ||
| layers: ["top", "bottom"], | ||
| hole_width: 3.2, | ||
| hole_height: 1.6, | ||
| rect_pad_width: 4.5, | ||
| rect_pad_height: 2.4, | ||
| rect_pad_border_radius: 0.6, | ||
| }, | ||
| { | ||
| type: "pcb_plated_hole", | ||
| pcb_plated_hole_id: "ph-pill-vertical", | ||
| x: 10, | ||
| y: 8, | ||
| shape: "pill_hole_with_rect_pad", | ||
| layers: ["top", "bottom"], | ||
| hole_width: 1.6, | ||
| hole_height: 3.2, | ||
| rect_pad_width: 2.4, | ||
| rect_pad_height: 4.5, | ||
| rect_pad_border_radius: 0.6, | ||
| }, | ||
| ] as const | ||
|
|
||
| export const RoundedRectPadsDemo = () => ( | ||
| <CadViewer circuitJson={roundedRectPadsCircuit as any} /> | ||
| ) | ||
|
|
||
| export default { | ||
| title: "Rounded Geometry", | ||
| component: RoundedRectPadsDemo, | ||
| } |
There was a problem hiding this comment.
The file name RoundedRectPads.stories.tsx does not follow the project's kebab-case naming convention. Rename the file to rounded-rect-pads.stories.tsx to maintain consistency with the established naming pattern used throughout the codebase.
Spotted by Diamond (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
seveibar
approved these changes
Oct 2, 2025
techmannih
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.