PCB Support #1
PCB Support #1
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
| // Calculate pad position relative to component center | ||
| const relativeX = pcbPad.x - component.center.x | ||
| const relativeY = pcbPad.y - component.center.y | ||
|
|
There was a problem hiding this comment.
Pad coordinates are computed in circuit-json space (relativeX/relativeY) and then written directly into FootprintPad.at. Because the PCB converter’s matrix in CircuitJsonToKicadPcbConverter applies a Y‑axis flip (scale of -1) and possible scaling, the footprint origin is transformed but the pads are not, so every pad is mirrored vertically and scaled incorrectly relative to its component center. Any non‑symmetric footprint will appear flipped on the generated PCB. Apply the same circuit‑to‑KiCad transform (or at least the Y inversion) to the pad offsets before assigning them.
Useful? React with 👍 / 👎.
| // Determine net number | ||
| let netNumber = 0 | ||
| if (pcbNetMap && via.net_name) { | ||
| netNumber = pcbNetMap.get(via.net_name) ?? 0 |
There was a problem hiding this comment.
Vias look up their net number with pcbNetMap.get(via.net_name) but the only entries put into pcbNetMap come from AddNetsStage, which synthesises names like Net-${trace.pcb_trace_id} instead of the original net_name. Unless the JSON’s via net names happen to already be in that synthetic format, every via falls through to netNumber = 0, so all vias are exported as no‑net/GND regardless of the actual connectivity. The net map should be populated with the real circuit JSON net identifiers (and traces should reference those same names) before vias are added.
Useful? React with 👍 / 👎.
No description provided.