Skip to content

Fix schematic traces not connected #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix schematic traces not connected #14

wants to merge 1 commit into from

Conversation

@kavitasaini1999
Copy link

PR Summary

  • Offset schematic library drawing primitives by each symbol’s reported center so the rendered graphics line up with the schematic component placement grid.
  • Calculate KiCad pin coordinates from center-relative offsets, ensuring generated wires now terminate exactly on the associated symbol pins

fixes #12
/claim #12

@algora-pbc algora-pbc bot mentioned this pull request Oct 7, 2025
Closed
seveibar
seveibar requested changes Oct 7, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the snapshots, the text is now intersecting the symbol

seveibar
seveibar reviewed Oct 7, 2025
View reviewed changes
lib/schematic/stages/AddLibrarySymbolsStage.ts
const cx = center?.x ?? 0
const cy = center?.y ?? 0
const xyPoints = points.map(
(p) => new Xy((p.x - cx) * scale, (p.y - cy) * scale),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use transformation-matrix to perform any operations on points, e.g. the applyToPoint method. Never do point math with multiplication without a transformation-matrix

seveibar
seveibar reviewed Oct 7, 2025
View reviewed changes
lib/schematic/stages/AddLibrarySymbolsStage.ts
points: Array<{ x: number; y: number }>,
scale: number,
center: { x: number; y: number } | undefined,
fillType: "none" | "background" = "none",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a 2 parameter rule, if there's more than 2 parameters you must switch to named parameters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seveibar seveibar seveibar requested changes

Assignees

No one assigned

Labels

🙋 Bounty claim

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix schematic traces not connected to schematic symbols

2 participants

@kavitasaini1999 @seveibar