Skip to content

Conversation

@seveibar
Copy link
Contributor

@seveibar seveibar commented Oct 3, 2025

Summary

  • run the bun test workflow inside the KiCad 9.0 docker container instead of installing packages on the runner

Testing

  • bunx tsc --noEmit
  • bun run format

https://chatgpt.com/codex/tasks/task_b_68e012863758832ebe83231cd804cc02

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting

Comment on lines 22 to 26
- name: Checkout code
uses: actions/checkout@v4

- name: Cache KiCad packages
id: cache-kicad
uses: actions/cache@v4
with:
path: |
/var/cache/apt/archives
/usr/share/kicad
/usr/bin/kicad-cli
key: kicad-${{ runner.os }}-9.0

- name: Install KiCad CLI
if: steps.cache-kicad.outputs.cache-hit != 'true'
run: |
sudo add-apt-repository --yes ppa:kicad/kicad-9.0-releases
sudo apt update
sudo apt install --yes kicad
- name: Setup bun
uses: oven-sh/setup-bun@v2

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Ensure job container provides Node.js (and git) for actions

The workflow now runs every step inside ghcr.io/kicad/kicad:9.0 (lines 14‑16) but the image is a KiCad runtime and does not ship the toolchain that GitHub’s JavaScript actions depend on (Node.js and, typically, git). Because actions/checkout@v4 and oven-sh/setup-bun@v2 run inside the container, they will fail with node: not found/git: command not found, so the job never reaches bun test. The container needs to install these utilities or the job should continue using the hosted runner for actions.

Useful? React with 👍 / 👎.

@seveibar seveibar merged commit c7b5946 into main Oct 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants