-
Notifications
You must be signed in to change notification settings - Fork 8
Use KiCad docker image in CI tests #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use KiCad docker image in CI tests #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Cache KiCad packages | ||
| id: cache-kicad | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| /var/cache/apt/archives | ||
| /usr/share/kicad | ||
| /usr/bin/kicad-cli | ||
| key: kicad-${{ runner.os }}-9.0 | ||
|
|
||
| - name: Install KiCad CLI | ||
| if: steps.cache-kicad.outputs.cache-hit != 'true' | ||
| run: | | ||
| sudo add-apt-repository --yes ppa:kicad/kicad-9.0-releases | ||
| sudo apt update | ||
| sudo apt install --yes kicad | ||
| - name: Setup bun | ||
| uses: oven-sh/setup-bun@v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure job container provides Node.js (and git) for actions
The workflow now runs every step inside ghcr.io/kicad/kicad:9.0 (lines 14‑16) but the image is a KiCad runtime and does not ship the toolchain that GitHub’s JavaScript actions depend on (Node.js and, typically, git). Because actions/checkout@v4 and oven-sh/setup-bun@v2 run inside the container, they will fail with node: not found/git: command not found, so the job never reaches bun test. The container needs to install these utilities or the job should continue using the hosted runner for actions.
Useful? React with 👍 / 👎.
Summary
Testing
https://chatgpt.com/codex/tasks/task_b_68e012863758832ebe83231cd804cc02