Skip to content

Refactor circuitJsonToSpice into modular helpers #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactor circuitJsonToSpice into modular helpers #12

wants to merge 1 commit into from

Conversation

@seveibar
Copy link
Contributor

@seveibar seveibar commented Oct 5, 2025

Summary

  • split the circuitJsonToSpice implementation into focused helpers for node mapping, component creation, and simulation voltage sources
  • extract value formatting, identifier sanitization, and simulation switch control logic into reusable utilities
  • add a shared type for simulation switches used during SPICE generation

Testing

  • bunx tsc --noEmit
  • bun test tests

https://chatgpt.com/codex/tasks/task_b_68e213af6cb4832ebf79196a0f9183a8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

codex

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@seveibar