via clearance errors #303
Merged
via clearance errors #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveibar
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+5
to
+33
| test("pcb_via_clearance_error parses", () => { | ||
| const error = pcb_via_clearance_error.parse({ | ||
| type: "pcb_via_clearance_error", | ||
| message: "vias too close", | ||
| pcb_via_ids: ["via_1", "via_2"], | ||
| minimum_clearance: "0.2mm", | ||
| actual_clearance: "0.1mm", | ||
| pcb_center: { | ||
| x: 12.5, | ||
| y: -3.4, | ||
| }, | ||
| }) | ||
|
|
||
| expect(error.pcb_error_id).toBeDefined() | ||
| expect(error.pcb_error_id.startsWith("pcb_error")).toBe(true) | ||
| expect(error.minimum_clearance).toBeCloseTo(0.2) | ||
| expect(error.actual_clearance).toBeCloseTo(0.1) | ||
| expect(error.pcb_center).toEqual({ x: 12.5, y: -3.4 }) | ||
| }) | ||
|
|
||
| test("any_circuit_element includes pcb_via_clearance_error", () => { | ||
| const parsed = any_circuit_element.parse({ | ||
| type: "pcb_via_clearance_error", | ||
| message: "vias too close", | ||
| pcb_via_ids: ["via_1", "via_2"], | ||
| }) | ||
|
|
||
| expect(parsed.type).toBe("pcb_via_clearance_error") | ||
| }) |
There was a problem hiding this comment.
This test file violates the testing rule by containing 2 test() calls (lines 5 and 25). Test files are limited to AT MOST one test() call per file. Split these tests into separate numbered files: pcb_via_clearance_error1.test.ts and pcb_via_clearance_error2.test.ts, with each file containing only one test() call.
Spotted by Diamond (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_b_68e1b1c5dec8832eb5fb48ed5a9dea1e