Fix autorouter routing through board outline, Add autorouter U-outline regression snapshot #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
1
to
50
| import { expect, test } from "bun:test" | ||
| import { getTestFixture } from "tests/fixtures/get-test-fixture" | ||
| import { getSimpleRouteJsonFromCircuitJson } from "lib/utils/autorouting/getSimpleRouteJsonFromCircuitJson" | ||
|
|
||
| const uShapedOutline = [ | ||
| { x: -6, y: -6 }, | ||
| { x: -2, y: -6 }, | ||
| { x: -2, y: 2 }, | ||
| { x: 2, y: 2 }, | ||
| { x: 2, y: -6 }, | ||
| { x: 6, y: -6 }, | ||
| { x: 6, y: 6 }, | ||
| { x: -6, y: 6 }, | ||
| ] | ||
|
|
||
| test("simple route json includes board outline when provided", async () => { | ||
| const { circuit } = getTestFixture() | ||
|
|
||
| circuit.add( | ||
| <board | ||
| outline={uShapedOutline} | ||
| autorouter={{ | ||
| local: true, | ||
| groupMode: "subcircuit", | ||
| }} | ||
| > | ||
| <resistor | ||
| name="R1" | ||
| resistance="1k" | ||
| footprint="0402" | ||
| pcbX={-4} | ||
| pcbY={-4} | ||
| /> | ||
| <resistor name="R2" resistance="1k" footprint="0402" pcbX={4} pcbY={-4} /> | ||
| <trace from=".R1 > .pin2" to=".R2 > .pin2" /> | ||
| </board>, | ||
| ) | ||
|
|
||
| await circuit.renderUntilSettled() | ||
|
|
||
| const { simpleRouteJson } = getSimpleRouteJsonFromCircuitJson({ | ||
| db: circuit.db, | ||
| }) | ||
|
|
||
| expect(simpleRouteJson.outline).toBeDefined() | ||
| expect(simpleRouteJson.outline).toHaveLength(uShapedOutline.length) | ||
| expect(simpleRouteJson.outline).toEqual(uShapedOutline) | ||
|
|
||
| expect(circuit).toMatchPcbSnapshot(import.meta.path) | ||
| }) |
There was a problem hiding this comment.
The test file name simple-route-json-outline.test.tsx violates the project's naming convention. Test files with the *.test.ts extension may contain at most one test(...) function. When multiple tests are needed, they should be split into numbered files (e.g., add1.test.ts, add2.test.ts). Since this file contains only one test, it should be renamed to follow the convention, such as simple-route-json-outline1.test.tsx or use a more descriptive name that reflects the specific test's purpose.
Spotted by Diamond (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
seveibar
changed the title
seveibar
deleted the
codex/update-capacity-autorouter-for-outline-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_b_68df59bb16c0832e829d0a91fc50736c