Add analog simulation element and spice engine map #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+1
to
+16
| import { expectTypesMatch } from "lib/typecheck" | ||
| import { z } from "zod" | ||
|
|
||
| export interface AnalogSimulationProps { | ||
| simulationType?: "spice_transient_analysis" | ||
| } | ||
|
|
||
| export const analogSimulationProps = z.object({ | ||
| simulationType: z | ||
| .literal("spice_transient_analysis") | ||
| .default("spice_transient_analysis"), | ||
| }) | ||
|
|
||
| expectTypesMatch<AnalogSimulationProps, z.input<typeof analogSimulationProps>>( | ||
| true, | ||
| ) |
There was a problem hiding this comment.
The file name 'analogsimulation.ts' violates the file naming convention rule. File names should be consistent with the project and generally use kebab-case. This file should be renamed to 'analog-simulation.ts' to follow the kebab-case convention. The export name 'AnalogSimulationProps' suggests the file should use kebab-case separation between 'analog' and 'simulation'.
Spotted by Diamond (based on custom rule: Custom rule)
Is this helpful? React 👍 or 👎 to let us know.
This comment came from an experimental review—please leave feedback if it was helpful/unhelpful. Learn more about experimental comments here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_b_68e04c473808832e92bf544965a522b8