-
Notifications
You must be signed in to change notification settings - Fork 81
Fix settings link and redirect to user-specific settings page #1752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
import { useEffect, useState } from "react" | ||
import { Redirect } from "wouter" | ||
|
||
import { FullPageLoader } from "@/App" | ||
import { useGlobalStore } from "@/hooks/use-global-store" | ||
|
||
const SettingsRedirectPage = () => { | ||
const session = useGlobalStore((state) => state.session) | ||
const [hasHydrated, setHasHydrated] = useState(() => { | ||
if (typeof window === "undefined") return false | ||
return useGlobalStore.persist?.hasHydrated?.() ?? false | ||
}) | ||
|
||
useEffect(() => { | ||
if (typeof window === "undefined") return | ||
|
||
if (useGlobalStore.persist?.hasHydrated?.()) { | ||
setHasHydrated(true) | ||
return | ||
} | ||
|
||
const unsubFinishHydration = useGlobalStore.persist?.onFinishHydration?.( | ||
() => { | ||
setHasHydrated(true) | ||
}, | ||
) | ||
|
||
return () => { | ||
unsubFinishHydration?.() | ||
} | ||
}, []) | ||
|
||
if (!hasHydrated) { | ||
return <FullPageLoader /> | ||
} | ||
|
||
if (!session?.github_username) { | ||
return <Redirect to="/" /> | ||
} | ||
|
||
return <Redirect to={`/${session.github_username}/settings`} /> | ||
} | ||
|
||
export default SettingsRedirectPage | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File naming inconsistency: The file
settings-redirect.tsx
uses kebab-case but does not match the exported component nameSettingsRedirectPage
. Fix by either:SettingsRedirectPage.tsx
to match the export name, orSettingsRedirect
to align with the kebab-case file nameConsistent naming conventions improve code maintainability and follow established project patterns.
Spotted by Diamond (based on custom rule: Custom rule)

Is this helpful? React 👍 or 👎 to let us know.