Skip to content

Add eslint-plugin-qunit and tighten JS tests #32270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 15, 2021
Merged

Add eslint-plugin-qunit and tighten JS tests #32270

merged 8 commits into from
Sep 15, 2021

Conversation

@XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Nov 27, 2020 •
edited
Loading

TODO:

  • Address the remaining lint errors
  • assert.expect(0)??
  • Search for assert.ok and assert.notOk and convert any tests that can be converted
  • Change VERSION checks to check for length !== 0 too ?

@XhmikosR XhmikosR force-pushed the v4-dev-xmr-eslint-qunit branch from aee44b7 to ce74282 Compare November 27, 2020 12:08
@XhmikosR

This comment has been minimized.

Sign in to view
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-eslint-qunit branch from 47ceebb to 1360a3f Compare December 20, 2020 15:30
@XhmikosR XhmikosR added the tests label Dec 20, 2020
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-eslint-qunit branch 2 times, most recently from 59f14ee to f4c74fc Compare February 4, 2021 05:50
@twbs twbs deleted a comment from Tubay2222 Jul 9, 2021
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-eslint-qunit branch 10 times, most recently from e4b56d6 to 389d696 Compare September 8, 2021 07:35
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-eslint-qunit branch 2 times, most recently from ed578f8 to f6499b2 Compare September 15, 2021 11:58
@XhmikosR XhmikosR marked this pull request as ready for review September 15, 2021 12:08
@XhmikosR XhmikosR requested a review from a team as a code owner September 15, 2021 12:08
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-eslint-qunit branch from f6499b2 to 4c0a7cf Compare September 15, 2021 12:09
@XhmikosR XhmikosR force-pushed the v4-dev-xmr-eslint-qunit branch 2 times, most recently from ff7c991 to cd5d2b8 Compare September 15, 2021 12:23
@XhmikosR XhmikosR mentioned this pull request Sep 15, 2021
Open
@rishisqsh rishisqsh mentioned this pull request Sep 20, 2024
Open
@blakegreendev blakegreendev mentioned this pull request Sep 21, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Sep 21, 2024
Open
@ryanwittmers ryanwittmers mentioned this pull request Sep 21, 2024
Open
@tiff-es tiff-es mentioned this pull request Sep 22, 2024
Open
@blakegreendev blakegreendev mentioned this pull request Sep 22, 2024
Open
@dingo4dev dingo4dev mentioned this pull request Sep 22, 2024
Closed
This was referenced Sep 22, 2024
Open
Open
Open
Open
Open
Open
Open
@RohitM-IN RohitM-IN mentioned this pull request Sep 29, 2024
Open
@imsureshbala imsureshbala mentioned this pull request Sep 29, 2024
Open
This was referenced Sep 30, 2024
Open
Open
Open
Open
Open
@saadi1995 saadi1995 mentioned this pull request Oct 5, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 5, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Oct 30, 2024
Open
@snyk-kevin snyk-kevin mentioned this pull request Nov 3, 2024
Open
@leopard1982 leopard1982 mentioned this pull request Nov 3, 2024
Open
@RohitM-IN RohitM-IN mentioned this pull request Nov 6, 2024
Open
This was referenced Aug 19, 2025
Closed
Closed
@dependabot dependabot bot mentioned this pull request Aug 26, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GeoSot GeoSot GeoSot approved these changes

Assignees

No one assigned

Labels

js no squash tests v4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@XhmikosR @GeoSot