Skip to content

Conversation

manisha1997
Copy link
Contributor

Fixes

User agent will use PHP_OS in case the method php_uname is disabled in certain environment.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@manisha1997 manisha1997 linked an issue Sep 18, 2025 that may be closed by this pull request
Copy link

@shrutiburman shrutiburman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public function testDefaultUserAgent(): void {

Please also add a test in here

@manisha1997
Copy link
Contributor Author

public function testDefaultUserAgent(): void {

Please also add a test in here

This test is already here
What other test case I can add?

@shrutiburman
Copy link

public function testDefaultUserAgent(): void {

Please also add a test in here

This test is already here What other test case I can add?

The test case present checks for user-agent regex.
we have added an extra if block, can we mock and see what is the value added by PHP_OS ? How are the values different in each situation and if not different, testcase to verify that.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Call to undefined function Twilio\Base\php_uname()
2 participants