Skip to content

Updates based on Rackspace feedback #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 3, 2014
Merged

Updates based on Rackspace feedback #2

merged 3 commits into from
Dec 3, 2014

Conversation

JPry
Copy link

@JPry JPry commented Dec 3, 2014

I've made the changes mentioned by Jamie Hannaford:

  • Update the class name from CertificateMappings to CertificateMapping
  • Use camel case for a variable name
  • Combine two separate loops into one loop

tylerturk added a commit that referenced this pull request Dec 3, 2014
@tylerturk
Merge pull request #2 from JPry/jpry_certificate_mappings
4dd3f4c 
Updates based on Rackspace feedback
@tylerturk tylerturk merged commit 4dd3f4c into tylerturk:certificate_mappings Dec 3, 2014
@JPry JPry deleted the jpry_certificate_mappings branch January 14, 2015 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JPry @tylerturk