update for StrOrPromise in typeddjango/django-stubs #301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencehonles
force-pushed
the
update-for-StrOrPromise
branch
from
4d9e133 to
9845a97
Compare
intgr
force-pushed
the
update-for-StrOrPromise
branch
from
9845a97 to
451ec09
Compare
intgr
requested changes
Dec 3, 2022
Contributor
intgr
left a comment
intgr
left a comment
There was a problem hiding this comment.
Thanks! I rebased this to fix the CI issues on master.
But a few .yml test cases need to be updated in this branch as well, since mypy messages changed.
intgr
reviewed
Dec 3, 2022
Contributor
|
@terencehonles Are you up to it to fix the CI here? |
Closed
Contributor
It seems like author has abandoned the PR and project I maintain needs DRF stubs bump - I've fixed tests and created a new PR here #331 |
intgr
force-pushed
the
update-for-StrOrPromise
branch
from
451ec09 to
c7cb58d
Compare
intgr
approved these changes
Feb 3, 2023
Contributor
intgr
left a comment
intgr
left a comment
There was a problem hiding this comment.
Great! I've force pushed @piotrszyma 's test fixes from #331. I'll add a Co-authored-by: tag though.
Contributor
Author
|
Thanks for taking care of this, I have been rather busy and didn't notice the notifications. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
StrOrPromiseupdates after typeddjango/django-stubs#689Related issues