Add plugin for categorizing cpu performance #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwhite4
reviewed
Jul 8, 2021
src/supremm/assets/mongo_setup.js
Outdated
| } | ||
| }, | ||
| "cpucategories": { | ||
| "documentation": "The CpuCategories plugin uses CPU utilization metrics to categorize a job as good, pinned, unpinned, or low. A job is good if every core is heavily utilized, and a job is low if the cores are barely utilized or not at all. A pinned job consists of a scenario where a subset of the cores does most of the work, while an unpinned job is when the work is spread unevenly across many cores.", |
There was a problem hiding this comment.
Suggested change
| "documentation": "The CpuCategories plugin uses CPU utilization metrics to categorize a job as good, pinned, unpinned, or low. A job is good if every core is heavily utilized, and a job is low if the cores are barely utilized or not at all. A pinned job consists of a scenario where a subset of the cores does most of the work, while an unpinned job is when the work is spread unevenly across many cores.", | |
| "documentation": "Categorization of the CPU utilization of the job as good, pinned, unpinned, or low. A job is good if every core is heavily utilized, and a job is low if the cores are barely utilized or not at all. A pinned job consists of a scenario where a subset of the cores does most of the work, while an unpinned job is when the work is spread unevenly across many cores.", |
jpwhite4
reviewed
Jul 8, 2021
src/supremm/plugins/CpuCategories.py
Outdated
| self._deltas[node] = {} | ||
| self._maxcores[node] = 0 | ||
|
|
||
| if proc is None: |
There was a problem hiding this comment.
pesudo suggestion
if proc is None and 'cpusallowed' not in proc and node not in proc['cpusallowed'] . .....
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin categorizes a job based on its CPU performance. Adds a PCP archive for the integration test.