Remove Prometheus-specific configuration for PCP setup #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change prevents any settings specific to Prometheus from appearing in resources configured with PCP.
Motivation
I was looking through a configuration file in a dev environment and noticed that some default settings for Prometheus were present for a PCP-configured resource. This bug functionally has no impact on summarization of PCP data, however, it can be very confusing for a user to see Prometheus settings in PCP-configured resources.
Tests
Tested by running
supremm-setupin the CI docker container. I configured both a PCP and Prometheus resource to ensure the data source settings are mutually exclusive.