-
Notifications
You must be signed in to change notification settings - Fork 106
chore: Migrate to angular 20 #527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+14,716
−7,454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View your CI Pipeline Execution ↗ for commit 83840a9
☁️ Nx Cloud last updated this comment at |
Closed
rakesh-athirajula
approved these changes
Jul 28, 2025
sheikalthaf
approved these changes
Jul 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various updates across multiple files to streamline configurations, modernize dependencies, and remove unused code. Key changes include updates to Node.js versions in workflows, removal of the
ngu-carousel-e2e
project and its associated files, and improvements to Angular configurations.Workflow and Dependency Updates:
.github/workflows/nodejs.yml
to include version22
and in.github/workflows/npm-publish.yml
to version20
, ensuring compatibility with newer Node.js features. [1] [2] [3]Removal of
ngu-carousel-e2e
Project:ngu-carousel-e2e
project, including its Cypress configuration, ESLint rules, project schema, and all related test files. This cleanup eliminates unused testing infrastructure. [1] [2] [3] [4] [5] [6] [7] [8] [9]Angular Configuration Enhancements:
apps/ngu-carousel-example/project.json
to simplify JSON formatting and add acontinuous
flag for development configurations. [1] [2] [3] [4]provideExperimentalZonelessChangeDetection
withprovideZonelessChangeDetection
inapp.config.ts
to use the stable API.provideServerRendering
inapp-server.config.ts
to reflect the latest Angular SSR module.Minor Improvements:
.all-contributorsrc
for better readability. [1] [2]README.md
for better badge alignment.closes #525