-
Notifications
You must be signed in to change notification settings - Fork 137
Open
Description
The error that occurred in stream reading is ignored now.
ethgo/jsonrpc/transport/websocket.go
Lines 91 to 98 in f671bdb
| var err error | |
| buf, err = s.codec.Read(buf[:0]) | |
| if err != nil { | |
| if !s.isClosed() { | |
| // log error | |
| } | |
| return | |
| } |
When we subscribe an event and get no messages, we can not know if the underlying websocket connection is healthy(the network may be down).
Maybe we should add a callback for all unexpected connection errors.
eg.
Subscribe(method string, callback func(b []byte), errHandler func(err error)) (func() error, error)
ferranbt
Metadata
Metadata
Assignees
Labels
No labels