-
Notifications
You must be signed in to change notification settings - Fork 1
Release v0.2.15 #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.2.15 #14
Conversation
scwatts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've also bumped the version of bolt here, I think that is probably accidental
|
I did it because of how the container names work. With One alternative approach could be to add the tool version in the tag like |
|
I may misunderstand, is this PR aiming to also create the bolt 0.2.15 release? Or is it more that you're trying to bump gpgr and wanting to use the CICD to build images, which needs the workaround described to avoid name clashes? |
|
This PR is primarily aiming to bump GPGR to version 0.2.2. The bolt version bump to 0.2.15 is workaround for the container clashes |
|
Thanks for the details, I think I understand that you're wanting to bump gpgr to 2.2.0 (I believe 0.2.2 is a typo) and test this in sash I have a couple suggestions here:
|
|
I've already tested this with the latest gpgr in bolt. It's what sash on ICA for OA v2.2.0 is currently using. No other changes are needed to support OA v2.2.0, so I was thinking of making this a small bump version so that ICA doesn't have to work on a branch. But since it's functional, I could alternatively add this change to the bolt release/0.3.0 linked to sash v0.7.0 release. which would require more testing. |
|
Thanks for the extra context, this is making sense now. I see two options:
Up to you how you'd prefer to handle! |
0866526 to
ce86f45
Compare
|
Taking this activity as you proceeding with 0.2.15 release option :) I'll approve the other PR shortly |
CHANGELOG.md
Outdated
|
|
||
| ## dev | ||
|
|
||
| - [14](https://github.com/umccr/bolt/pull/14) - gpgr version bump to 0.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to 2.2.0
docker/Dockerfile.gpgr
Outdated
| RUN \ | ||
| conda install --prefix /env/ \ | ||
| 'r-gpgr ==2.1.3' \ | ||
| 'r-gpgr ==2.2.0' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit shouldn't be included in this PR; the set of commits in this PR should be merged with main or rebased on main
I can rebase if you like after you make the adjustment to the CHANGELOG.md file above
31b12b8 to
ce86f45
Compare
scwatts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thanks for making those adjustments!
No description provided.