Fix wiki URLs in README.md #152
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Feb 4, the name of the top-level wiki page was changed from "Python Slugify Wiki" to "Welcome to the python-slugify wiki!". That change to the wiki page title changed all the URLs for the wiki pages. If you tried to click a wiki URL in the README.md, GitHub would redirect you to a form to create a new wiki page with that name. Fix this by updating the URLs in README.md to match the new wiki top page title. TODO: I don't know if there are other wiki URLs in other documentation files. The instances in README.md were the ones I have time to fix while quickly trying to use python-slugify for a personal project. Thanks for all your work maintaining this project!
|
Ah, it seems the instructions on the wiki for sending in a pull request are incorrect? The instructions say to open a PR against the CI branch. However, the CI branch seems to be missing some commits from the main branch, so this GitHub PR automatically tried to add them. I'm not as familiar with GitHub process flow (most of my projects I have commit rights to), so please have patience with me. I'll double check I didn't skip any steps in the instructions. |
|
Thank you for this PR. It will be pulled in on the next update cycle, along with at least one hot issue. |
|
@un33k This may have slipped through the cracks. I'm pinging you because it appears to still be relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit description.