Keep initial subscriptions alive #30
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@akofman Hi and thanks for the PR. Could you please add a test case that reproduces this against |
Contributor
|
@akofman We've been able to verify both that this is an issue and that our tests were broken. I'll get back to you once we've resolved both. |
Contributor
Author
|
Cool, sorry I didn't have time to create a test case reproducing that ... If you still need my help , do not hesitate. |
simenbrekken
pushed a commit
that referenced
this pull request
Mar 6, 2017
…ing subscriptions Closes #30
simenbrekken
pushed a commit
that referenced
this pull request
Mar 6, 2017
Contributor
Author
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello guys,
I think your last commits removed the already existing subscriptions and imply some errors when trying to unsubscribe a non-existant listener. I guess it's because in the previous version was used a
reducefunction instead of themapValues.Hope it's ok for you.