-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/gefyra integration #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @buschNT ! Thank you so much for you great work on the caching (and integrating Gefyra)!
I think most things are pretty much style stuff.
However one main thing is actually missing - in case we're talking about a "cache" the objects stored in the cache need to have some kind of lifetime or timeout.
This concept is pretty much missing which will lead to outdated data in some cases.
I would suggest to implement something like __getitem__ (see this awesome stackoverflow post: https://stackoverflow.com/questions/43627405/understanding-getitem-method).
This is combination with a timeout would allow the cache to detect outdated data which needs to be refreshed. It can continue refreshing on its own then.
That's why I mentioned that we need some kind of timeout for the stored data.
|
Another thing - the dependency |
Co-authored-by: Robert Stein <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|








No description provided.