Skip to content

Conversation

@buschNT
Copy link
Contributor

@buschNT buschNT commented Mar 2, 2022

No description provided.

Copy link
Contributor

@SteinRobert SteinRobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @buschNT ! Thank you so much for you great work on the caching (and integrating Gefyra)!

I think most things are pretty much style stuff.

However one main thing is actually missing - in case we're talking about a "cache" the objects stored in the cache need to have some kind of lifetime or timeout.

This concept is pretty much missing which will lead to outdated data in some cases.

I would suggest to implement something like __getitem__ (see this awesome stackoverflow post: https://stackoverflow.com/questions/43627405/understanding-getitem-method).
This is combination with a timeout would allow the cache to detect outdated data which needs to be refreshed. It can continue refreshing on its own then.

That's why I mentioned that we need some kind of timeout for the stored data.

@SteinRobert
Copy link
Contributor

Another thing - the dependency gefyra is missing in requirements.txt and setup.py.

@buschNT buschNT marked this pull request as ready for review May 5, 2022 07:25
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 24 Code Smells

No Coverage information No Coverage information
2.1% 2.1% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants