New flow changes #100
Open
New flow changes #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxIsJoe
suggested changes
Aug 10, 2025
corp-0
requested changes
Aug 10, 2025
| @@ -0,0 +1,3 @@ | |||
| meta { | |||
| name: SHAChecks | |||
Member
There was a problem hiding this comment.
don't commit bruno files. It was good before we had any auto documentation on the endpoints but now it will just confuse other developers. I'd say you can even remove the whole api-collection folder
| except Account.DoesNotExist: | ||
| return Response({"error": "Account not found"}, status=status.HTTP_404_NOT_FOUND) | ||
|
|
||
| # Try to get character, otherwise create a new one |
Member
There was a problem hiding this comment.
maybe this should just patch existing ones. Why create when you have an endpoint for that?
Member
Author
There was a problem hiding this comment.
Makes more resilient code so, if you update but it doesn't exist then, it stops you from losing your character?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is missing the job to clear out the old sha tokens
And maybe the time Expiry for character settings token?