fix(trimer): Fix IL2026 JSON warnings in src/Uno.UI #21722
+8
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21722/docs/index.html |
jonpryor
force-pushed
the
dev/jonpryor/jonp-Uno.UI-JSON-il2026
branch
from
c11457d to
623fbf2
Compare
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21722/docs/index.html |
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21722/wasm-skia-net9/index.html |
|
|
Context: https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming Context: https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/source-generation#specify-options When building `src/Uno.UI` with trimmer warnings enabled (and turned up to 11): dotnet build src/Uno.UI/Uno.UI.Skia.csproj -bl \ -p:TrimmerSingleWarn=false -p:_ExtraTrimmerArgs=--verbose -p:IsTrimmable=true -p:IsAotCompatible=true Many of the warnings are around System.Text.Json usage: …/src/Uno.UI/UI/Xaml/FontManifestHelpers.cs(34,6): error IL2026: Using member 'System.Text.Json.JsonSerializer.Deserialize<TValue>(Stream, JsonSerializerOptions)' which has 'RequiresUnreferencedCodeAttribute' can break functionality when trimming application code. JSON serialization and deserialization might require types that cannot be statically analyzed. Use the overload that takes a JsonTypeInfo or JsonSerializerContext, or make sure all of the required types are preserved. Update `JsonSerializer.Deserialize<TValue>()` usage to remove the IL2026 warnings. Specifically, update `CoreWebView2WebMessageReceivedEventArgs.cs` to use `JsonSerializer.Deserialize<string>(string, JsonTypeInfo<string>)`, providing a `JsonTypeInfo<string>` derived from a `JsonSerializerOptions` instance that only supports strings. Update `FontManifest*.cs` to use [`JsonSourceGenerationOptionsAttribute`][0] so that System.Text.Json source generation can generate an appropriate `JsonSerializerOptions`. This allows us to use `JsonSerializer.Deserialize<FontManifest>(Stream, JsonSerializerContext)`. [0]: https://learn.microsoft.com/en-us/dotnet/api/system.text.json.serialization.jsonsourcegenerationoptionsattribute?view=net-9.0
jonpryor
force-pushed
the
dev/jonpryor/jonp-Uno.UI-JSON-il2026
branch
from
623fbf2 to
517e860
Compare
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21722/wasm-skia-net9/index.html |
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21722/docs/index.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://learn.microsoft.com/en-us/dotnet/core/deploying/trimming/prepare-libraries-for-trimming
Context: https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/source-generation#specify-options
When building
src/Uno.UIwith trimmer warnings enabled (and turned up to 11):Many of the warnings are around System.Text.Json usage:
Update
JsonSerializer.Deserialize<TValue>()usage to remove the IL2026 warnings.Specifically, update
CoreWebView2WebMessageReceivedEventArgs.csto useJsonSerializer.Deserialize<string>(string, JsonTypeInfo<string>), providing aJsonTypeInfo<string>derived from aJsonSerializerOptionsinstance that only supports strings.Update
FontManifest*.csto useJsonSourceGenerationOptionsAttributeso that System.Text.Json source generation can generate an appropriateJsonSerializerOptions. This allows us to useJsonSerializer.Deserialize<FontManifest>(Stream, JsonSerializerContext).GitHub Issue: closes #
PR Type:
What is the current behavior? 🤔
What is the new behavior? 🚀
PR Checklist ✅
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information ℹ️