Skip to content
This repository was archived by the owner on Jan 27, 2025. It is now read-only.

Replace moment with date-fns #103

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Replace moment with date-fns #103

merged 2 commits into from
Jul 23, 2020

Conversation

ivesdebruycker
Copy link
Contributor

See #84

scaredcat
scaredcat reviewed May 2, 2020
View reviewed changes
Copy link
Contributor

@scaredcat scaredcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good. A couple of pointers:

  1. Please replace moment in stories/index.js so that storybook can continue to work. You can test by running yarn storybook

  2. Please ensure linting passes (also done by travis). You can ignore the warnings

@scaredcat scaredcat requested a review from jlo-1 June 22, 2020 01:33
@jlo-1
Copy link
Contributor

jlo-1 commented Jul 23, 2020

Excellent, thanks for contributing 👍

@jlo-1 jlo-1 merged commit be9ba8c into uptick:master Jul 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jlo-1 jlo-1 Awaiting requested review from jlo-1

1 more reviewer

@scaredcat scaredcat scaredcat left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ivesdebruycker @jlo-1 @scaredcat