This repository was archived by the owner on Jan 27, 2025. It is now read-only.
Bump react-dnd version and fix folder creation when rename is disabled #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ziaulrehman40
commented
May 20, 2020
ziaulrehman40
commented
- Fully fixes onCreateFolder is not called if onRenameFolder is not provided #107 and partially fixes Bump react-dnd #27
- react dnd bumped to version 8.x, as version 9+ has deprecated decorators and HOCs and will cause us to refactor parts of the app(which we should anyway)
|
Just so you know this is helping me tackle #109 as well, with help of react-dnd/react-dnd#1345 (comment) as data was missing in older version of react-dnd and i wasted a day trying to figure out why is it so, turned out we were on very old version of react-dnd |
|
Great work. Thanks for the PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.