This repository was archived by the owner on Jan 27, 2025. It is now read-only.
Enable showing folders on filter #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge origin to fork
scaredcat
suggested changes
Jun 22, 2020
src/browser.js
Outdated
| actions: PropTypes.node, | ||
| showActionBar: PropTypes.bool.isRequired, | ||
| canFilter: PropTypes.bool.isRequired, | ||
| showFoldersOnFilter: PropTypes.bool.isRequired, |
There was a problem hiding this comment.
this prop should not be required. The default of false should be enough to keep backwards compatibility
|
Thanks for the contribution. Changes will be added to the next release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added showFoldersOnFilter prop which enable showing folders when filtering.