This repository was archived by the owner on Jan 27, 2025. It is now read-only.
Webpack 4 and Storybooks #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarekwg
reviewed
Mar 5, 2019
jarekwg
reviewed
Mar 5, 2019
| icons, canFilter, filterRendererProps, | ||
| filterRenderer: FilterRenderer, onCreateFolder, | ||
| onRenameFile, onRenameFolder, onDeleteFile, onDeleteFolder, | ||
| onRenameFile, onRenameFolder, onDeleteFile, onDeleteFolder, onDownloadFile, |
There was a problem hiding this comment.
Not sure about adding downLoadFile.. In our own implementation, this sits within the detail view renderer. Is there something more generic we could offer, for users to build their own actions?
jarekwg
reviewed
Mar 5, 2019
jarekwg
reviewed
Mar 5, 2019
jarekwg
reviewed
Mar 5, 2019
| FolderOpen: <i className="fa fa-folder-open-o" aria-hidden="true" />, | ||
| Delete: <i className="fa fa-trash-o" aria-hidden="true" />, | ||
| Loading: <i className="fa fa-circle-o-notch fa-spin" aria-hidden="true" />, | ||
| Download: <i className="fa fa-download" aria-hidden="true" />, |
There was a problem hiding this comment.
Can the mappings here be just from object to class, rather than rendering the whole tag?
ie.
Image: fa fa-image-o,
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes fixes for the following Issues:
#45
Includes PRs:
#46
#47