This repository was archived by the owner on Jan 27, 2025. It is now read-only.
Add a renderer for actions #72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds customization support to the action buttons
scaredcat
suggested changes
Nov 28, 2019
delete and rename actions were showing when they shouldn't have
scaredcat
approved these changes
Nov 28, 2019
Comment on lines
+168
to
+172
| if (actions.length) { | ||
| actions = (<ul className="item-actions">{actions}</ul>) | ||
| } else { | ||
| actions = (<div className="item-actions"> </div>) | ||
| } |
There was a problem hiding this comment.
this could be moved right before returning actions which means you could delete the other identical block.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds customization support to the action buttons
this can help with #19 until proper localization support is implemented