This repository was archived by the owner on Jan 27, 2025. It is now read-only.
Make browserProps available on ActionRenderer #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the other renderers have it and can be very useful when using a user-defined ActionRenderer
scaredcat
approved these changes
Dec 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the other renderers have it and can be very useful when using a
user-defined ActionRenderer
Personally I found this useful because I'm using a custom ActionRenderer to translate the action buttons to my language and style the buttons, but now I wan to add a new button to the action bar and this allows me to pass a new prop to and have it available on ActionRenderer via browserProps