feat: migrate cache deletion to Twirp backend #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Should only merge this once the following are merged and deployed: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
aadityasondhi
force-pushed
the
20250714.twirp-delete
branch
from
4ca3f59 to
cc6cfb7
Compare
aayushshah15
requested changes
Jul 14, 2025
Contributor
aayushshah15
left a comment
aayushshah15
left a comment
There was a problem hiding this comment.
We need to run the codegen and include the generated code changes here I think
BREAKING CHANGE: Migrated from REST API to Twirp RPC protocol - Changed endpoint from REST DELETE to Twirp POST /DeleteCacheEntry - Updated request format to use JSON body with 'key', 'version', 'prefix' fields - Removed unused repoName and region parameters - Updated tests to match new API structure - Fixed response handling to use 'count' field instead of 'deleted' This aligns with the github.actions.results.api.v1.CacheService proto definition
aadityasondhi
force-pushed
the
20250714.twirp-delete
branch
from
cc6cfb7 to
a98c8a2
Compare
Contributor
Author
done |
aayushshah15
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Migrated from REST API to Twirp RPC protocol
This aligns with the github.actions.results.api.v1.CacheService proto definition