Mh update pillow 2024 - Fix tests and extraction of invalid bboxes #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The information originates in chars, but is pushed to words, lines and boxes in case the values don't differ.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get the update branch running, handling of bboxes from annotations should be improved.
If invalid bboxes are recognized, the bboxes are NOT used to extract text from annotations.
This would lead to expected exceptions in the used libraries.
Instead, ignore those boxes.
This had some issues with the tests, invalid bboxes could not be tested cause they are not extracted.
The internal structure of pdfplumber changed, figures are now images. Therefore tests must be adapted.