Added Apply Chat Template #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusDunn
requested changes
Mar 3, 2024
Closed
|
Very useful feature, can’t wait! |
|
Checking in on this. Has anything with this functionality been added yet? If not, I'll make the requested changes |
|
There's some overlap with #194, otherwise nothing comes to mind. |
MarcusDunn
approved these changes
Apr 5, 2024
MarcusDunn
approved these changes
Apr 5, 2024
|
The windows build failing is fine, but could you look into why the Linux Cuda one is failing? Looks like a i8 vs u8 pointer difference. |
6f9fa32 should fix it. That is actually a really interesting error. Whether c_char is an *i8 or *u8 is dependent on the architecture which is why I was not getting an error: https://doc.rust-lang.org/std/os/raw/type.c_char.html |
|
awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LlamaCPP added support for chat templates a few weeks ago: ggml-org/llama.cpp#5538
This adds a method on the model struct to apply a chat template.