Addressing #6 - public client: token_endpoint_auth_method should be none (RefreshTokenGrant)
#9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uvdsl
changed the title
uvdsl
changed the title
token_endpoint_auth_method should be none (RefreshTokenGrant)
This was
linked to
issues
May 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR competes with #7.
In this version, we rely on the RefreshTokenGrant to restore a session.
For persistence, we use the IndexedDB API as discussed here.
We do not use Silent Authentication which addresses the concern regarding the IDPs session cookies being
SameSite=None.This PR provides a clear improvement in terms of security compared to the current main version.
The current version stores
client_secretandrefresh_tokeninsessionStorage, which is equivalent to storing an (extractable) DPoP KeyPair insessionStorage. Because we store a non-extractable DPoP KeyPair via the IndexedDB API we reduce the risk surface of this library, and follow the Best Current Practice.