fix: add hidden property to polymer based components #171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
fix/boolean-attributes
branch
from
fec6207 to
2c4a4c4
Compare
tomivirkki
commented
Dec 13, 2023
|
|
||
| useChaiPlugin(chaiDom); | ||
|
|
||
| describe('SideNav', () => { |
There was a problem hiding this comment.
Added tests for SideNav because it's LitElement based and behaves differently from the other, PolymerElement based components.
web-padawan
reviewed
Dec 13, 2023
web-padawan
reviewed
Dec 13, 2023
tomivirkki
changed the title
web-padawan
approved these changes
Dec 13, 2023
vaadin-bot
pushed a commit
that referenced
this pull request
Dec 15, 2023
web-padawan
pushed a commit
that referenced
this pull request
Dec 15, 2023
web-padawan
pushed a commit
that referenced
this pull request
Dec 15, 2023
Co-authored-by: Tomi Virkki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Map falsy boolean properties asundefinedto avoid them from rendering with the valuefalsein the attribute, for example,<vaadin-button hidden="false">, which would actually evaluate ashiddenbeingtruedue to it being a boolean attribute.Add
hiddenproperty to Polymer-based components to have it not set as an attributeFixes #118
Type of change
Bugfix