Skip to content

Multiple types defining a Valkey node network address #227

@adam-fowler

Description

@adam-fowler

We currently have
1 - ValkeyServerAddress
2 - ValkeyNodeDescription
3 - ValkeyNodeDescriptionProtocol.
4 - ValkeyNodeID

  • 2, 3 and 4 all assume the network address is defined by an endpoint and a port.
  • 1 also allows for defining the address using a unix domain socket.
  • 2 and 3 include values host and ip which aren't used
  • 4 is hashable. There is currently a PR for cluster pipelined commands which requires 1 to be hashable
  • 1 and 3 are public symbols
  • Everything eventually boils down to 1 when a node client is built

Questions:

  • Do we need host and ip variables?
  • Can we replace 2 and 4 with 1?
  • What advantage does using the protocol ValkeyNodeDescriptionProtocol have over requiring the user to provide a concrete address type?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions