Skip to content

Conversation

adam-fowler
Copy link
Collaborator

@adam-fowler adam-fowler commented Sep 12, 2025

  • Also moved integration tests, testing commands into separate file
  • Added command test helper testCommandEncodesDecodes and use in script and server commands, will extend to others in separate PR

@adam-fowler adam-fowler marked this pull request as draft September 12, 2025 16:28
Copy link

github-actions bot commented Sep 12, 2025

❌ Pull request has performance regressions ❌

Summary
==============================================================================
Threshold deviations for ValkeyBenchmarks:Connection: Pipeline array benchmark
==============================================================================
Malloc (total) (K, %) main pull_request Difference % Threshold %
p75 38 43 14 5

New baseline 'pull_request' is WORSE than the 'main' baseline thresholds.

Full Benchmark Comparison

Comparing results between 'main' and 'pull_request'

Host '1e34e72de1b5' with 4 'x86_64' processors with 15 GB memory, running:
#18~24.04.1-Ubuntu SMP Sat Jun 28 04:46:03 UTC 2025

ValkeyBenchmarks

Client: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 82 82 83 87 88 88 88 6
pull_request 83 84 85 87 88 88 88 6
Δ 1 2 2 0 0 0 0 0
Improvement % -1 -2 -2 0 0 0 0 0

Client: GET benchmark | parallel 20 | 20 concurrent connections metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 94 99 102 107 109 117 117 24
pull_request 94 99 103 106 110 114 114 24
Δ 0 0 1 -1 1 -3 -3 0
Improvement % 0 0 -1 1 -1 3 3 0

Connection: GET benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 4 4 4 4 4 4 4 8
pull_request 4 4 4 4 4 4 4 8
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

Connection: GET benchmark – NoOpTracer metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 7 8 8 10 10 10 10 8
pull_request 7 8 8 10 10 10 10 8
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

Connection: Pipeline array benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 37 37 37 38 43 43 43 4
pull_request 37 37 38 43 43 43 43 5
Δ 0 0 1 5 0 0 0 1
Improvement % 0 0 -3 -13 0 0 0 1

Connection: Pipeline benchmark metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 36 36 37 37 37 37 37 5
pull_request 36 36 37 37 37 37 37 5
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

HashSlot – {user}.whatever metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 19
pull_request 0 0 0 0 0 0 0 19
Δ 0 0 0 0 0 0 0 0
Improvement % 0 0 0 0 0 0 0 0

ValkeyCommandEncoder – Command with 7 words metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 741
pull_request 0 0 0 0 0 0 0 720
Δ 0 0 0 0 0 0 0 -21
Improvement % 0 0 0 0 0 0 0 -21

ValkeyCommandEncoder – Simple GET metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 1877
pull_request 0 0 0 0 0 0 0 1834
Δ 0 0 0 0 0 0 0 -43
Improvement % 0 0 0 0 0 0 0 -43

ValkeyCommandEncoder – Simple MGET 15 keys metrics

Malloc (total): results within specified thresholds, fold down for details.

Malloc (total) * p0 p25 p50 p75 p90 p99 p100 Samples
main 0 0 0 0 0 0 0 356
pull_request 0 0 0 0 0 0 0 352
Δ 0 0 0 0 0 0 0 -4
Improvement % 0 0 0 0 0 0 0 -4

Signed-off-by: Adam Fowler <[email protected]>
Signed-off-by: Adam Fowler <[email protected]>
Add testCommandEncodesDecodes helper function

Signed-off-by: Adam Fowler <[email protected]>
@adam-fowler adam-fowler marked this pull request as ready for review September 13, 2025 14:31
@adam-fowler adam-fowler added this to the 1.0 milestone Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant