Skip to content

Add benchmark CI #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 26, 2024
Merged

Add benchmark CI #141

merged 11 commits into from
Mar 26, 2024

Conversation

ptoffy
Copy link
Member

@ptoffy ptoffy commented Feb 24, 2024 •
edited
Loading

All credit goes to @gwynne

@ptoffy ptoffy requested review from 0xTim and gwynne as code owners February 24, 2024 22:28
@ptoffy ptoffy mentioned this pull request Feb 24, 2024
Closed
gwynne
gwynne approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it actually works as written (I couldn't exactly test it, after all!), approved 😛

gwynne
gwynne requested changes Feb 24, 2024
View reviewed changes
Copy link
Member

@gwynne gwynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example, like that...

gwynne
gwynne reviewed Feb 24, 2024
View reviewed changes
ptoffy and others added 2 commits February 24, 2024 22:46
gwynne
gwynne reviewed Feb 24, 2024
View reviewed changes
0xTim
0xTim approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@0xTim 0xTim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - will let @gwynne approve as well

gwynne
gwynne approved these changes Mar 26, 2024
View reviewed changes
Benchmarks/Package.swift
.macOS(.v13),
],
dependencies: [
.package(path: "../"),
Copy link
Member

@gwynne gwynne Mar 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize this is the way this tooling works, but it makes me shudder just the same 🤦‍♀️

@ptoffy ptoffy merged commit 2999698 into main Mar 26, 2024
@ptoffy ptoffy deleted the update-ci branch March 26, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwynne gwynne gwynne approved these changes

@0xTim 0xTim 0xTim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ptoffy @gwynne @0xTim