(examples/with-webassembly) fixed for webpack 5 #26440
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitalybaev
requested review from
divmain,
ijjk,
leerob,
lfades,
shuding and
timneutkens
as code owners
leerob
approved these changes
Jun 21, 2021
3 tasks
flybayer
pushed a commit
to blitz-js/next.js
that referenced
this pull request
Jun 24, 2021
## Documentation / Examples - [x] Make sure the linting passes Fixes vercel#26436 As mention in vercel#25854 `with-webassembly` example doesn't work anymore after switching to webpack 5. This PR adds webpack experimental configuration.
bordeo
pushed a commit
to bordeo/next.js
that referenced
this pull request
Jul 12, 2021
v11.0.1 * tag 'v11.0.1': (374 commits) v11.0.1 v11.0.1-canary.8 Ensure image-types file is included (vercel#26495) Strongly type `Router.events.on` and `Router.events.off` (vercel#26456) v11.0.1-canary.7 Update i18n fields in docs (vercel#26492) Update to only add image import types when enabled (vercel#26485) Fix domain locales not available on client (vercel#26083) chore: Add Alex to lint documentation (vercel#26354) fix: ignore invalid accept-language header (vercel#26476) Add module.exports to security headers documentation (vercel#26466) (examples/with-webassembly) fixed for webpack 5 (vercel#26440) Add check for startLatency in fast refresh (vercel#26417) v11.0.1-canary.6 docs(router.md) Add note about page state and navigation (vercel#26320) Remove period for ESLint `passHref` docs link. (vercel#26402) Update with-eslint example. (vercel#25817) Docs: Add Prettier section on ESLint page (vercel#26347) add missing closing bracket (vercel#26375) Improve the `next/script` documentation. (vercel#26325) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation / Examples
Fixes #26436
As mention in #25854
with-webassemblyexample doesn't work anymore after switching to webpack 5.This PR adds webpack experimental configuration.