Skip to content

Update middleware-upgrade-guide to be consistent #38102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2022
Merged

Update middleware-upgrade-guide to be consistent #38102

merged 1 commit into from
Jun 28, 2022

Conversation

@dominiksipowicz
Copy link
Member

@dominiksipowicz dominiksipowicz commented Jun 28, 2022

Ensure that before and after examples are consistent

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The examples guidelines are followed from our contributing doc

@dominiksipowicz
Update middleware-upgrade-guide.md
47e066b 
Ensure that before and after examples are consistent
@dominiksipowicz
Copy link
Member Author

dominiksipowicz commented Jun 28, 2022

CC @leerob

balazsorban44
balazsorban44 approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balazsorban44 balazsorban44 merged commit a90349d into vercel:canary Jun 28, 2022
@dominiksipowicz dominiksipowicz deleted the patch-1 branch June 28, 2022 15:39
@snyk-bot snyk-bot mentioned this pull request Jul 20, 2022
Open
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dominiksipowicz @balazsorban44 @ijjk