Skip to content

Remove obsolete ("remove after next minor") #60930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: canary
Choose a base branch
from
Open

Remove obsolete ("remove after next minor") #60930

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
243e87a
remove obsolete warnings
alexdln Jan 21, 2024
6063d78
remove obsolete warnings p2
alexdln Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions packages/next/src/build/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1733,12 +1733,6 @@ export async function isPageStatic({
? {}
: componentsResult.pageConfig

if (config.unstable_includeFiles || config.unstable_excludeFiles) {
Log.warn(
`unstable_includeFiles/unstable_excludeFiles has been removed in favor of the option in next.config.js.\nSee more info here: https://nextjs.org/docs/advanced-features/output-file-tracing#caveats`
)
}

let isStatic = false
if (!hasStaticProps && !hasGetInitialProps && !hasServerProps) {
isStatic = true
Expand Down
13 changes: 1 addition & 12 deletions packages/next/src/build/webpack/loaders/next-flight-css-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,10 @@ const NextServerCSSLoader: webpack.LoaderDefinitionFunction<NextServerCSSLoaderO
function (content) {
this.cacheable && this.cacheable()
const options = this.getOptions()
let isCSSModule = options.cssModules
const isCSSModule = options.cssModules

// Only add the checksum during development.
if (process.env.NODE_ENV !== 'production') {
// This check is only for backwards compatibility.
// TODO: Remove this in the next major version (next 14)
if (isCSSModule === undefined) {
this.emitWarning(
new Error(
"No 'cssModules' option was found for the next-flight-css-loader plugin."
)
)
isCSSModule =
this.resourcePath.match(/\.module\.(css|sass|scss)$/) !== null
}
const checksum = crypto
.createHash('sha1')
.update(typeof content === 'string' ? Buffer.from(content) : content)
Expand Down
19 changes: 0 additions & 19 deletions packages/next/src/server/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,25 +310,6 @@ function assignDefaults(
)
}

// TODO: remove after next minor (current v13.1.1)
if (Array.isArray(result.experimental?.outputFileTracingIgnores)) {
if (!result.experimental) {
result.experimental = {}
}
if (!result.experimental.outputFileTracingExcludes) {
result.experimental.outputFileTracingExcludes = {}
}
if (!result.experimental.outputFileTracingExcludes['**/*']) {
result.experimental.outputFileTracingExcludes['**/*'] = []
}
result.experimental.outputFileTracingExcludes['**/*'].push(
...(result.experimental.outputFileTracingIgnores || [])
)
Log.warn(
`\`outputFileTracingIgnores\` has been moved to \`experimental.outputFileTracingExcludes\`. Please update your ${configFileName} file accordingly.`
)
}

if (result.basePath !== '') {
if (result.basePath === '/') {
throw new Error(
Expand Down
10 changes: 0 additions & 10 deletions packages/next/types/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,16 +148,6 @@ export type PageConfig = {
runtime?: ServerRuntime
unstable_runtimeJS?: false
unstable_JsPreload?: false
/**
* @deprecated this config has been removed in favor of the next.config.js option
*/
// TODO: remove in next minor release (current v13.1.1)
unstable_includeFiles?: string[]
/**
* @deprecated this config has been removed in favor of the next.config.js option
*/
// TODO: remove in next minor release (current v13.1.1)
unstable_excludeFiles?: string[]
}

export {
Expand Down