Turbopack: fix side effects optimization bug

test/development/acceptance/ReactRefreshLogBox.test.ts

@@ -180,8 +180,8 @@ describe('ReactRefreshLogBox', () => {
              |       ^",
            "stack": [
              "[project]/index.js [ssr] (ecmascript) index.js (3:7)",
-             "<FIXME-next-dist-dir>",
-             "<FIXME-next-dist-dir>",
+             "[project]/pages/index.js [ssr] (ecmascript) <module evaluation> pages/index.js (1:1)",
+             "[project]/pages/index.js [ssr] (ecmascript) pages/index.js (1:1)",
              "<FIXME-next-dist-dir>",
            ],
          }

turbopack/crates/turbopack-ecmascript/src/references/mod.rs

@@ -276,6 +276,7 @@ impl AnalyzeEcmascriptModuleResultBuilder {
     /// If you're unsure about which function to use, use `add_reference()`
     pub fn add_esm_evaluation_reference(&mut self, idx: usize) {
         self.esm_references.insert(idx);
+        self.esm_local_references.insert(idx);
         self.esm_evaluation_references.insert(idx);
     }
 

turbopack/crates/turbopack-tests/tests/execution/turbopack/side-effects-optimization/basic/input/index.js

@@ -1,3 +1,20 @@
+import {
+  a as a0,
+  b as b0,
+  c as c0,
+  d as d0,
+  e as e0,
+  def as def0,
+} from "package-named";
+it("should optimize named reexports from side effect free module", () => {
+  expect(a0).toBe("a");
+  expect(b0).toBe("b");
+  expect(c0).toBe("x");
+  expect(d0).toBe("y");
+  expect(e0).toBe("x");
+  expect(def0).toBe("default");
+});
+
 import {
   a as a1,
   b as b1,
@@ -7,8 +24,8 @@ import {
   local as local1,
   default as default1,
   def as def1,
-} from "package-named";
-it("should optimize named reexports from side effect free module", () => {
+} from "package-named-local";
+it("should optimize named reexports with locals from side effect free module", () => {
   expect(a1).toBe("a");
   expect(b1).toBe("b");
   expect(c1).toBe("x");
@@ -19,11 +36,10 @@ it("should optimize named reexports from side effect free module", () => {
   expect(def1).toBe("default");
 });
 
-import { a as a2, b as b2, local as local2 } from "package-star";
+import { a as a2, b as b2 } from "package-star";
 it("should optimize star reexports from side effect free module", () => {
   expect(a2).toBe("a");
   expect(b2).toBe("b");
-  expect(local2).toBe("local");
 });
 
 import {

turbopack/crates/turbopack-tests/tests/execution/turbopack/side-effects-optimization/follow-keeps-side-effect/input/index.js

@@ -0,0 +1,5 @@
+import getValue from "./reexport.js";
+
+it("should not optimize away side effects", () => {
+  expect(getValue()).toBe(42);
+});

turbopack/crates/turbopack-tests/tests/execution/turbopack/side-effects-optimization/follow-keeps-side-effect/input/package.json

@@ -0,0 +1,6 @@
+{
+  "sideEffects": [
+    "./index.js",
+    "./valueSetter.js"
+  ]
+}

turbopack/crates/turbopack-tests/tests/execution/turbopack/side-effects-optimization/follow-keeps-side-effect/input/reexport.js

@@ -0,0 +1,7 @@
+import { value } from "./valueSetter.js";
+
+export { value } from "./valueSetter.js";
+
+export default () => {
+    return value
+}

turbopack/crates/turbopack-tests/tests/execution/turbopack/side-effects-optimization/follow-keeps-side-effect/input/valueContainer.js

@@ -0,0 +1,4 @@
+export let value = undefined;
+export function setValue(newValue) {
+    value = newValue;
+}

turbopack/crates/turbopack-tests/tests/execution/turbopack/side-effects-optimization/follow-keeps-side-effect/input/valueSetter.js

@@ -0,0 +1,3 @@
+import { setValue } from "./valueContainer.js";
+setValue(42);
+export * from "./valueContainer.js";

turbopack/crates/turbopack-tests/tests/execution/turbopack/side-effects-optimization/follow-keeps-side-effect/options.json

@@ -0,0 +1,3 @@
+{
+  "treeShakingMode": "reexports-only"
+}

turbopack/crates/turbopack-tests/tests/execution/turbopack/tree-shaking/follow-keeps-side-effect/input/index.js

@@ -0,0 +1 @@
+import "../../../side-effects-optimization/follow-keeps-side-effect/input/index.js";

turbopack/crates/turbopack-tests/tests/execution/turbopack/tree-shaking/follow-keeps-side-effect/options.json

@@ -0,0 +1,3 @@
+{
+  "treeShakingMode": "module-fragments"
+}