Skip to content

Turbopack: avoid tracking a modification when adding an already existing item #78726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Turbopack: avoid tracking a modification when adding an already existing item #78726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions turbopack/crates/turbo-tasks-backend/src/backend/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1501,7 +1501,7 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {

// handle stateful
if stateful {
task.insert(CachedDataItem::Stateful { value: () });
let _ = task.add(CachedDataItem::Stateful { value: () });
}

// handle cell counters: update max index and remove cells that are no longer used
Expand Down Expand Up @@ -1938,7 +1938,7 @@ impl<B: BackingStorage> TurboTasksBackendInner<B> {
.entry(RawVc::TaskCell(collectible.task, collectible.cell))
.or_insert(0) += count;
}
task.insert(CachedDataItem::CollectiblesDependent {
let _ = task.add(CachedDataItem::CollectiblesDependent {
collectible_type,
task: reader_id,
value: (),
Expand Down
5 changes: 4 additions & 1 deletion turbopack/crates/turbo-tasks-backend/src/backend/operation/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ use std::{
};

use serde::{Deserialize, Serialize};
use turbo_tasks::{SessionId, TaskId, TurboTasksBackendApi};
use turbo_tasks::{KeyValuePair, SessionId, TaskId, TurboTasksBackendApi};

use crate::{
backend::{
Expand Down Expand Up @@ -466,6 +466,9 @@ impl<B: BackingStorage> TaskGuard for TaskGuardImpl<'_, B> {
let category = item.category();
self.check_access(category);
if !self.task_id.is_transient() && item.is_persistent() {
if self.task.contains_key(&item.key()) {
return false;
}
self.task.track_modification(category.into_specific());
}
self.task.add(item)
Expand Down
Loading