Skip to content

Turbopack: use unstable sort for better performance #78764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025
Merged

Turbopack: use unstable sort for better performance #78764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion turbopack/crates/turbo-persistence/src/collector.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ impl<K: StoreKey, const SIZE_SHIFT: usize> Collector<K, SIZE_SHIFT> {
/// Sorts the entries and returns them along with the total key and value sizes. This doesn't
/// clear the entries.
pub fn sorted(&mut self) -> (&[CollectorEntry<K>], usize, usize) {
self.entries.sort_by(|a, b| a.key.cmp(&b.key));
self.entries.sort_unstable_by(|a, b| a.key.cmp(&b.key));
(&self.entries, self.total_key_size, self.total_value_size)
}

Expand Down
2 changes: 1 addition & 1 deletion turbopack/crates/turbo-persistence/src/write_batch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ impl<K: StoreKey + Send + Sync, const FAMILIES: usize> WriteBatch<K, FAMILIES> {

shared_error.into_inner()?;
let seq = self.current_sequence_number.load(Ordering::SeqCst);
new_sst_files.sort_by_key(|(seq, _)| *seq);
new_sst_files.sort_unstable_by_key(|(seq, _)| *seq);
Ok(FinishResult {
sequence_number: seq,
new_sst_files,
Expand Down
Loading