Skip to content

[test] Move test selectors as close to the actual value as possible #78931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025
Merged

[test] Move test selectors as close to the actual value as possible #78931

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions test/e2e/app-dir/dynamic-io/app/headers/exercise/components.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,8 @@ function Get({
return (
<section>
<h2>{expression}.get('...')</h2>
<div id={'get-x-sentinel'}>
<pre>{headers.get('x-sentinel')}</pre>
<div>
<pre id={'get-x-sentinel'}>{headers.get('x-sentinel')}</pre>
</div>
</section>
)
Expand Down Expand Up @@ -194,8 +194,8 @@ function ForEach({
headers.forEach((value, header) => {
if (header.startsWith('x-sentinel')) {
output.push(
<div key={header} id={'for-each-' + header}>
<pre>{value}</pre>
<div key={header}>
<pre id={'for-each-' + header}>{value}</pre>
</div>
)
}
Expand Down Expand Up @@ -300,8 +300,8 @@ function ForOf({
for (let [headerName, value] of headers) {
if (headerName.startsWith('x-sentinel')) {
output.push(
<div key={headerName} id={'for-of-' + headerName}>
<pre>{value}</pre>
<div key={headerName}>
<pre id={'for-of-' + headerName}>{value}</pre>
</div>
)
}
Expand All @@ -326,8 +326,8 @@ function Spread({
.filter(([headerName]) => headerName.startsWith('x-sentinel'))
.map((v) => {
return (
<div key={v[0]} id={'spread-' + v[0]}>
<pre>{v[1]}</pre>
<div key={v[0]}>
<pre id={'spread-' + v[0]}>{v[1]}</pre>
</div>
)
})
Expand Down
Loading