Skip to content

Conversation

AlexandreSinger
Copy link
Contributor

@AlexandreSinger AlexandreSinger commented May 25, 2024

See issue #2557 for more context.

Removed the uses of std::iterator that were very simple to remove. These just required declaring some types that the users of the iterators expect and removing the inheritance on the std::iterator.

The other cases in VTR which use std::iterator are a bit more complicated and may require some work to remove correctly.

@AlexandreSinger AlexandreSinger changed the title Remove Simple Uses of STD Iterator Removed Simple Uses of STD Iterator May 25, 2024
@AlexandreSinger
Copy link
Contributor Author

@vaughnbetz This has passed CI, and the warnings pertaining to these specific uses of std::iterator are gone from the GCC12 build. What do you think about these changes?

@vaughnbetz vaughnbetz merged commit 630be48 into verilog-to-routing:master May 27, 2024
@vaughnbetz
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants